From 061fc34fccd875ba26099021891a93a5b129bb3e Mon Sep 17 00:00:00 2001 From: Michael Puncel Date: Fri, 7 Aug 2020 19:37:38 -0400 Subject: [PATCH] address PR comments Signed-off-by: Michael Puncel --- source/extensions/filters/http/lua/lua_filter.cc | 2 +- test/extensions/filters/http/lua/lua_filter_test.cc | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/source/extensions/filters/http/lua/lua_filter.cc b/source/extensions/filters/http/lua/lua_filter.cc index dea1e8ada016..4a3431df1d7e 100644 --- a/source/extensions/filters/http/lua/lua_filter.cc +++ b/source/extensions/filters/http/lua/lua_filter.cc @@ -602,7 +602,7 @@ int StreamHandleWrapper::luaImportPublicKey(lua_State* state) { } int StreamHandleWrapper::luaBase64Escape(lua_State* state) { - // Get input string + // Get input string. absl::string_view input = luaL_checkstring(state, 2); auto output = absl::Base64Escape(input); lua_pushlstring(state, output.data(), output.length()); diff --git a/test/extensions/filters/http/lua/lua_filter_test.cc b/test/extensions/filters/http/lua/lua_filter_test.cc index 35a44c0c697d..801eaae5ea22 100644 --- a/test/extensions/filters/http/lua/lua_filter_test.cc +++ b/test/extensions/filters/http/lua/lua_filter_test.cc @@ -2198,9 +2198,9 @@ TEST_F(LuaHttpFilterTest, LuaFilterBase64Escape) { request_handle:logTrace(base64Encoded) end - function envoy_on_response(request_handle) - local base64Encoded = request_handle:base64Escape("barfoo") - request_handle:logTrace(base64Encoded) + function envoy_on_response(response_handle) + local base64Encoded = response_handle:base64Escape("barfoo") + response_handle:logTrace(base64Encoded) end )EOF"};