-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log stderr of stack exec ghc
for better feedback
#254
Conversation
cc @bubba |
Can you test this with a clean |
Mmm and what about |
I will check! |
5c7ed09
to
8106dfc
Compare
@fendor your last push did not include the suggestion, did you have the opportunity of checking it? |
@jneira You are right, I basically forgot about this pr |
8106dfc
to
c2260cd
Compare
c2260cd
to
9a6f324
Compare
So, rebased this PR. I tested locally and CI is doing something similar, I think this PR is safe as it is |
@bubba noted above
Iirc we wanted to avoid the output from downloading the ghc to fix some issue in hls-wrapper |
EDIT, after reading the recently linked Issue, I agree, we should use the two commands. |
cac4a3c
to
65f409d
Compare
@jneira ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, many thanks!
* Log stderr of `stack exec ghc` for better feedback * Execute `stack setup` on its own * Add changes to ChangeLog (cherry picked from commit 84d4c37)
* Log stderr of `stack exec ghc` for better feedback * Execute `stack setup` on its own * Add changes to ChangeLog (cherry picked from commit 84d4c37)
From Freenode #haskell-ide-engine we had a line such as:
and you have to run
stack exec --silent ghc -- --numeric-version
to actually see the error.The error was then:
If this was included in the above log line, it would have been easier to debug.
Smoke testing showed that
--silent
is not necessary as such log output was sent to stderr.