Make runGhcCmd return CradleLoadResult #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
requested changes
Jul 7, 2020
src/HIE/Bios/Environment.hs
Outdated
Comment on lines
83
to
85
| -- | Gets the version of ghc used when compiling the cradle. It is based off of | ||
| -- 'getRuntimeGhcLibDir'. If it can't work out the verison reliably, it will | ||
| -- fall back to the version of ghc used to compile hie-bios. |
This way we can include better error messages when it fails
lukel97
force-pushed
the
runghccmd-cradleloadresult
branch
from
7887dd8 to
7a8f3e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.