Add component root directory

[fendor]

Supersedes #157

Implements the suggestion to wait until GHC is done parsing its flag to modify certain filepaths in DynFlags if they arent already absolute paths.

Con: Ghc options now may contain relative filepaths.
Pro: fixes bugs.

[jneira]

Hi, i am testing this version in the hls repo and i've got no error about the missing header, but neither compiler warnings or errors:

PS D:\dev\ws\haskell\hls> hie-bios check .\ghcide\src\Development\IDE\Core\Compile.hs      
hie-bios.exe: `gcc.exe' failed in phase `C pre-processor'. (Exit code: 1)
PS D:\dev\ws\haskell\hls> hie-bios.patch check .\ghcide\src\Development\IDE\Core\Compile.hs
hie-bios.patch.exe: module ‘Development.IDE.Compat’ cannot be found locally
.. rest of ghcide modules
module ‘Development.IDE.Plugin.Completions.Types’ cannot be found locally
PS D:\dev\ws\haskell\hls> cd .\ghcide\
PS D:\dev\ws\haskell\hls\ghcide> hie-bios check .\src\Development\IDE\Core\Compile.hs
src\Development\IDE\Core\Compile.hs:116:5:Empty 'do' block
PS D:\dev\ws\haskell\hls\ghcide> hie-bios.patch check .\src\Development\IDE\Core\Compile.hs
src\Development\IDE\Core\Compile.hs:116:5:Empty 'do' block

PS D:\dev\ws\haskell\hls> hie-bios.patch debug .\ghcide\src\Development\IDE\Core\Compile.hs: https://gist.github.com/jneira/0ee4c6c29fadaaa7f92f4348205f8b90

The ghc options now has -isrc instead -ighcide\src so it can't find the modules (and it continues having -Iinclude instead -Ighcide\include)

[fendor]

@jneira Thanks for the feedback!
I have yet to test it in depth! Apparently, I messed something up :)

[fendor]

With ghcide based on "multi-rebase", it seemed to work fine. Do you have a branch with HIE where you fixed the compilation that I can take a look at?

[jneira]

Do you have a branch with HIE where you fixed the compilation that I can take a look at?

I tried hls (current master, based on multi-rebase) at first but then i observed the result of calling directly hie-bios check .\ghcide\src\Development\IDE\Core\Compile.hs is the same.

could be the difference ghcide is a subproject for hls?

[fendor]

I dont know. Do you have a branch for it?
EDIT: Even if there is only a relative path for the hie-bios patch.

[jneira]

Mmm, i am not sure if i understand. I am in the project root dir of haskell-language-server, after checking out actual master:

PS D:\dev\ws\haskell\hls> cd ..
PS D:\dev\ws\haskell> cd hie-bios
PS D:\dev\ws\haskell\hie-bios> git status
On branch dont-mangle-ghc-options
Your branch is up to date with 'fendor/dont-mangle-ghc-options'.

nothing to commit, working tree clean
PS D:\dev\ws\haskell\hie-bios> cabal install
Wrote tarball sdist to
D:\dev\ws\haskell\hie-bios\dist-newstyle\sdist\hie-bios-0.4.0.tar.gz
Resolving dependencies...
Up to date
Copying 'hie-bios.exe'
PS D:\dev\ws\haskell\hie-bios> cd ..
PS D:\dev\ws\haskell> cd hls
PS D:\dev\ws\haskell\hls> git status
On branch master
Your branch is up to date with 'upstream/master'.

nothing to commit, working tree clean
PS D:\dev\ws\haskell\hls> hie-bios check .\ghcide\src\Development\IDE\Core\Compile.hs
hie-bios.exe: module ‘Development.IDE.Compat’ cannot be found locally
.....
module ‘Development.IDE.Plugin.Completions.Types’ cannot be found locally

[jneira]

@fendor the last commit makes hie-bios debug .\ghcide\...\Compile.hs works like a charm, many thanks!

I am gonna test it using as a lib in hls.

[jneira]

I've adapted hls to this branch and it can load ghcide modules! great work 👍

[alanz]

@jneira what is the next step?

[jneira]

@alanz haskell/haskell-language-server#64

[fendor]

@mpickering Are you fine with merging this?

[mpickering]

Generally good but please don't modify the interface to addCmdOpts.

[fendor]

Should this be part of the public API? Probably, but then I think a better name could be helpful?

[mpickering]

Looks good with a CHANGELOG entry as this may break ghcide.

[fendor]

ChangeLog is updated!

[mpickering]

Thanks. Great patch. Merge as you feel fit after squashing etc.