Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add CI/CD and semantic release #38

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

rmi22186
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Add semantic release and ci/cd scripts/config

Testing Plan

  • Was this tested locally? If not, explain why.
    It is not possible to test a github action prior to release. However, if there are any failures, we can debug once this file is in master.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Collaborator

@alexs-mparticle alexs-mparticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only one little reminder about secrets.

uses: crazy-max/ghaction-import-gpg@v4
with:
gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
passphrase: ${{ secrets.GPG_PASSPHRASE }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to migrate these secrets!

.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexs-mparticle alexs-mparticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only one little reminder about secrets.

@rmi22186
Copy link
Collaborator Author

rmi22186 commented Dec 1, 2023

@alexs-mparticle - yup i added the secrets yesterday also!

@rmi22186 rmi22186 changed the base branch from test/SQDSDKS-5984-karma-tests to development December 1, 2023 17:02
@rmi22186 rmi22186 force-pushed the ci/SQDSDKS-5985-github-actions branch from f1bb635 to 59d0a11 Compare December 1, 2023 17:04
@rmi22186 rmi22186 merged commit c0fb2ab into development Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants