-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add CI/CD and semantic release #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only one little reminder about secrets.
uses: crazy-max/ghaction-import-gpg@v4 | ||
with: | ||
gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} | ||
passphrase: ${{ secrets.GPG_PASSPHRASE }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to migrate these secrets!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only one little reminder about secrets.
@alexs-mparticle - yup i added the secrets yesterday also! |
f1bb635
to
59d0a11
Compare
Co-authored-by: Alex S <[email protected]>
Instructions
development
Summary
Add semantic release and ci/cd scripts/config
Testing Plan
It is not possible to test a github action prior to release. However, if there are any failures, we can debug once this file is in master.
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)