Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update karma test runner files #37

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

rmi22186
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Our Twitter web kit's tests were not consistent in folder structure. This PR makes it consistent with https://github.com/mparticle-integrations/mparticle-javascript-integration-criteo, which we did this most recently for.

Testing Plan

  • Was this tested locally? If not, explain why.
    Node tests still are successful, index.html tests are still successful.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Collaborator

@alexs-mparticle alexs-mparticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure the tests pass.

@rmi22186
Copy link
Collaborator Author

rmi22186 commented Dec 1, 2023

@alexs-mparticle tests passing now. it was missing the package-lock.json for the npm ci command

@rmi22186 rmi22186 merged commit 2ddf4c0 into development Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants