Skip to content

Commit

Permalink
Use devel version of covr, fix option
Browse files Browse the repository at this point in the history
Because this package uses C++11 covr needs to set a compiler flags to
turn on coverage. Prior to R-3.4 this option was called CXX1XFLAGS,
however from R-3.4 and on it is called CXX11FLAGS. The CRAN version of
covr only sets CXX1XFLAGS, so C++11 code doesn't get the `--coverage`
flag to turn on coverage tracking, which is why you were not getting
code coverage results.
  • Loading branch information
jimhester committed May 23, 2017
1 parent 45ede19 commit 12533f9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ notifications:

#after_success
after_success:
- Rscript -e "covr::codecov(excludes = 'src/sqlite3/sqlite3.c')"
- Rscript -e "covr::codecov(line_exclusions = 'src/sqlite3/sqlite3.c')"
#- R -q -e 'tic::after_success()'
#- Rscript -e "source ('https://install-github.me/MangoTheCat/goodpractice')"
#- Rscript -e 'library(goodpractice);gp(checks=all_checks()[grepl("(rcmdcheck|covr)",all_checks())])'
Expand Down
4 changes: 3 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ Suggests:
knitr,
rmarkdown,
roxygen2,
testthat
testthat,
covr
LinkingTo:
BH,
Rcpp
Expand All @@ -33,3 +34,4 @@ BugReports: https://github.com/mpadge/bikedata/issues
Encoding: UTF-8
LazyData: true
RoxygenNote: 6.0.1
Remotes: jimhester/covr

0 comments on commit 12533f9

Please sign in to comment.