-
Notifications
You must be signed in to change notification settings - Fork 102
Missing type info in the stacktrace #97
Comments
This sounds like a bug in the |
Spurred by your speedy response and confidence it’s an issue with the StackTraceFilter I’ve challenged my assumptions and dug into the SOAP library code, checked the So so sorry for wasting your time. Going to go and look at the other (more easily reproduced) part of the issue now (missing outer stacktrace) and will let you know how I get on. |
I'm not convinced yet about |
Sure, you may consider this a bug as it’s triggered by how you interact with the Throwable. Here… have a test case :) I’ve included one for <dependency>
<groupId>org.apache.axis</groupId>
<artifactId>axis</artifactId>
<version>1.4</version>
</dependency> @Test
public void remoteExceptionNotRemovedFromStackTrace() {
Throwable fault = new org.apache.axis.AxisFault("HTTP", "(401) Some error content", null, null);
Assert.assertTrue(StackTraceFilter.getFilteredStackTrace(fault).contains("AxisFault"));
}
@Test
public void exceptionNamePresentInPrintedStackTrace() {
StringWriter stackTraceWriter = new StringWriter();
Throwable fault = new org.apache.axis.AxisFault("HTTP", "(401) Some error content", null, null);
fault.printStackTrace(new PrintWriter(stackTraceWriter));
Assert.assertTrue(stackTraceWriter.toString().contains("AxisFault"));
} |
Thanks a lot for the concise test case. That should be fixed now with |
Great, I’ll take a look at some point soon and let you know. Thanks for the effort, and I’m pleased the test case was useful. |
We have noticed some missing info in the stacktraces which reach Kibana (via Logstash). I’ve not seen an example with a chained exception where the outermost exception’s stacktrace is printed (but that’s not this issue).
This issue is about the fact that sometimes the type of the exception is missing from the cause, and also sometimes from the outermost exception. I wondered if the StackTraceFilter could be causing the issue with missing types, but I’ve tested that from JUnit and can see that it only filters whole lines, not portions of lines. I’ve attached two example traces below.
There’s significant effort involved in disabling stacktrace filtering and redeploying so I wanted to check if anything jumped out at you first before I attempt to rule out Logback & Logstash. I also no longer have the files these logs got written to so a unable to compare their contents with what I see in Kibana.
The first starts with two lines beginning
Exception:
, but it looks like it just reports the message, not the exception type.The second starts okay, but has no actual stack elements for the exception, and no type for the cause.
The logstash-gelf version is
1.9.0
.The text was updated successfully, but these errors were encountered: