Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint causes build on windows to fail with default git settings #14

Closed
rmtmckenzie opened this issue Jan 12, 2017 · 2 comments
Closed

Comments

@rmtmckenzie
Copy link

Because ESLINT is set to need linefeeds set to LF, by default on windows building this will fail.

There's a few possible workarounds - the easiest being setting global git config core.autocrlf to force linefeeds to LF. However, this can break other programs' builds. A local git config can also be used but that doesn't help if using NPM to pull this repo.

I'm going to do a pull request for adding a .gitattributes file which forces line feeds to LF regardless of the git config for *.js files in the repo.

@T-vK
Copy link

T-vK commented Feb 16, 2017

All you need to do is edit the .eslintrc file. Change "linebreak-style": [2, "unix"], to "linebreak-style": [2, "windows"], when you are on Windows.

@Rob--W
Copy link
Member

Rob--W commented May 31, 2018

This was fixed by #103.

@Rob--W Rob--W closed this as completed May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants