Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

= Tailing Commas in JSON IE8 Error Fix #339

Merged
merged 1 commit into from
Mar 19, 2015
Merged

Conversation

pcting
Copy link
Contributor

@pcting pcting commented Mar 17, 2015

@RickEyre
Copy link
Contributor

Ha, wow. I would've thought .jshint would catch that.. Thank you! Can you remove dist/* changes? We run a build step which bumps the version at the same time on releases. I'll generate the build after we merge this.

@pcting
Copy link
Contributor Author

pcting commented Mar 18, 2015

@RickEyre yup, I reworked the commit

@gkatsev
Copy link
Contributor

gkatsev commented Mar 18, 2015

the esnext/node options for jshint seem to make it ignore that. Also, jshint 3.0 will be removing all styling options. There's JSCS for stylistic things: http://jscs.info/, it has a disallowTrailingComma option.

@RickEyre
Copy link
Contributor

@gkatsev ah I see. Thanks!

RickEyre added a commit that referenced this pull request Mar 19, 2015
= Tailing Commas in JSON IE8 Error Fix
@RickEyre RickEyre merged commit 0b4eab3 into mozilla:master Mar 19, 2015
@RickEyre
Copy link
Contributor

I'll publish this as soon as possible.

@RickEyre
Copy link
Contributor

Should be published now.

@pcting
Copy link
Contributor Author

pcting commented Mar 21, 2015

@RickEyre thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants