Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move templates from multi-line strings to their own files #1047

Closed
jhugman opened this issue Sep 1, 2021 · 1 comment · Fixed by #1065
Closed

Move templates from multi-line strings to their own files #1047

jhugman opened this issue Sep 1, 2021 · 1 comment · Fixed by #1065
Labels
binding-kotlin binding-swift good first issue Good for newcomers to get started with development

Comments

@jhugman
Copy link
Contributor

jhugman commented Sep 1, 2021 •
edited by data-sync-user
Loading

#993 and #1042 moved swift and kotlin types from one giant template file to many different multi-line strings in Rust.

This issue is about moving these multi-line strings in lots of small template files, so that syntax highlighting can work again for the foreign languages.

The types with the strings are in compounds.rs, primitives.rs and miscellany.rs.

┆Issue is synchronized with this Jira Task
┆Issue Number: UNIFFI-87
@jhugman jhugman added binding-kotlin binding-swift good first issue Good for newcomers to get started with development labels Sep 1, 2021
This was referenced Sep 1, 2021
Merged
Merged
@bendk bendk mentioned this issue Sep 5, 2021
Closed
@bendk
Copy link
Contributor

bendk commented Sep 5, 2021

This PR covers Kotlin, so just focus on Swift

This was referenced Sep 28, 2021
Merged
Merged
@jhugman jhugman mentioned this issue Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding-kotlin binding-swift good first issue Good for newcomers to get started with development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move foreign language Ffi converter logic out of rust strings, into templates. mozilla/uniffi-rs
2 participants
@jhugman @bendk