From 76331d761bf970ab4a20b3951d16529269f29503 Mon Sep 17 00:00:00 2001 From: Ben Dean-Kawamura Date: Thu, 23 Mar 2023 13:41:02 -0400 Subject: [PATCH] More review fixes --- fixtures/benchmarks/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fixtures/benchmarks/README.md b/fixtures/benchmarks/README.md index 482d650318..46d234436c 100644 --- a/fixtures/benchmarks/README.md +++ b/fixtures/benchmarks/README.md @@ -8,10 +8,10 @@ the foreign language: the benchmarks for. - `benchmarks.rs` executes a script for each foreign language that we want to benchmark. - Those scripts call the `run_benchmarks()` function from `lib.rs` - - `run_benchmarks()` parses the CLI arguments again, this time to how to setup + - `run_benchmarks()` parses the CLI arguments again, this time to determine how to setup the `Criterion` object. - Testing callback interfaces is relatively straightforward, we simply invoke the callback method. - Testing regular functions requires some extra care, since these are called by the foreign bindings. To test those, `benchmarks.rs` invokes a callback - interface method that call the rust function and reports the time taken. + interface method that calls the Rust function and reports the time taken.