Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskcluster tests run with a different version of taskgraph than decision tasks/training runs #440

Open
bhearsum opened this issue Feb 13, 2024 · 0 comments
Labels
taskcluster Issues related to the Taskcluster implementation of the training pipeline

Comments

@bhearsum
Copy link
Collaborator

I noticed this in #377 today, where I've pulled in a new version of taskgraph to pick up a helper function, but had the test task fail with an error that indicated an older version was being used.

Whenever taskgraph runs in CI, we use the version from https://github.com/mozilla/firefox-translations-training/blob/main/taskcluster/requirements.txt. When we run unit tests, we use whatever is in https://github.com/mozilla/firefox-translations-training/blob/main/poetry.lock.

In order to ensure that we always test with what we run on our infrastructure, we may want to consider moving Taskcluster unit testing to a separate target/task, and using the requirements from requirements.txt instead of poetry.lock.

@eu9ene eu9ene added the taskcluster Issues related to the Taskcluster implementation of the training pipeline label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
taskcluster Issues related to the Taskcluster implementation of the training pipeline
Projects
None yet
Development

No branches or pull requests

2 participants