Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to question topics performed inside the moderation tool brings the question under the "Needs Attention" filter #2107

Closed
emilghittasv opened this issue Jan 8, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@emilghittasv
Copy link
Collaborator

Describe the bug
One of our trusted contributors mentioned that:
Questions are arranged chronologically by the time of their last update. This seems to have become an unreliable way to identify new or newly updated questions. In the past hour, numerous threads with no responses or edits during the past 3 days have moved to the top of the list. Hopefully someone can fix this since it is making "Needs Attention" (https://support.mozilla.org/en-US/questions/all?show=needs-attention) kind of useless.

Preconditions
Sign in to SUMO with an account that has access to the moderation tool

Steps to reproduce
Steps to reproduce the behavior:

  1. Go to the https://support.allizom.org/en-US/moderate tool.
  2. Pick an old question and change it's topic.
  3. Navigate to the https://support.allizom.org/en-US/questions/all?show=needs-attention page

Expected behavior
The question is not added inside the attention needed filter as contributors are using that filter to filter for question updates in terms of comments or edits.

Actual behavior
The moderated question is added inside that filter.

Screencasts
topicUpdate

Desktop:

  • OS: Windows 11
  • Browser: Firefox

Additional context

  • This issue is reproducible in both stage and prod.
  • This issue is not reproducible while changing the question tags or updating the status/ticket inside the moderation tool. The only trigger from the moderation tools seems to be the change in topic
@emilghittasv emilghittasv added the bug Something isn't working label Jan 8, 2025
@github-project-automation github-project-automation bot moved this to ❓ triage in Mozilla Support Jan 8, 2025
@akatsoulas akatsoulas moved this from ❓ triage to 🚀 in progress in Mozilla Support Jan 9, 2025
@akatsoulas akatsoulas self-assigned this Jan 9, 2025
@akatsoulas
Copy link
Collaborator

akatsoulas commented Jan 9, 2025

This is not the bug but how it was designed to function. As explained in the description, the questions are ordered based on the last_update timestamp and this was used for the Needs Attention section. The problem arises from the update of the question with a new topic. This causes an update in the timestamp which moves the question to the top of the list again.

In order to solve for this, we are not going to update the timestamp when the change comes from the moderation queue.

@akatsoulas akatsoulas moved this from 🚀 in progress to 📚 review in Mozilla Support Jan 9, 2025
@akatsoulas
Copy link
Collaborator

PR mozilla/kitsune#6434

@akatsoulas akatsoulas moved this from 📚 review to 🔎 QA in Mozilla Support Jan 10, 2025
@emilghittasv
Copy link
Collaborator Author

I can confirm that this is verified in stage.

  • Performing any kind of updates via the moderation tool (change in topic, tags addition, ticket flag update) will not generate an update to the question to be moved or to take higher priority inside the "Needs Attention" filter.

No regressions found during verifying this ticket:

  • The attention filter orders questions which were updated (question title or question body) or in which the question creator has left a new reply.
  • The questions are order by the most recent updates first.
  • Changes performed inside the moderation tool (change in topics or tags additions) are successfully reflected at question level.

Moving this ticket inside the release column.

@emilghittasv emilghittasv moved this from 🔎 QA to 🚢 release in Mozilla Support Jan 10, 2025
@github-project-automation github-project-automation bot moved this from 🚢 release to ✔ done in Mozilla Support Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: done
Development

No branches or pull requests

2 participants