-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permission Delegation #230
Comments
@shhnjk I think a clarification would help here: I see Permission Delegation as part of Feature Policy. We have already a position on Feature Policy her #24. So is your question about implementing feature policy, or only about the UI part of how we are going to handle the frontend pieces of expressing this in permission prompts? |
Feature Policy defines new ways to allow/restrict the access to powerful features from cross-origin iframe, and also how to restrict certain features in own origin. But I think Feature Policy doesn't talk about:
Those things are defined by Permission Delegation (IMO, let me know if I'm wrong), which means it's not defined in any spec or standard. I'm asking the Mozilla Position on those things. |
|
I think you're right that standards-wise there are various loose ends to tie up and we've suggested at times to merge Feature Policy into Permissions, but as far as I know Chrome ships a very similar thing. Also, both your 1 and 2 above are very much up to the discretion of the user agent as they are defined today so what Firefox plans to ship here is well within bounds. |
Yes, but I'm asking about Mozilla Position😊
So what's the Mozilla Position here? It's up to the UA, so it doesn't matter and no security consideration is required? |
I'm not sure I understand the question in the last paragraph. Mozilla's position on the UI to present to users is similar to that of Chrome. I think we currently differ in how we want to treat wildcards (Firefox will prompt "again" in a way that should be somewhat clear to the user), but Jan-Ivar opened an issue against Feature Policy to discuss that further. |
So does Mozilla think this is a good solution? By showing top-frame origin in the prompt even though request comes from cross-origin iframe, you are removing the indicator of which origin is requesting access.
Could you explain more? What would happen if top-frame origin already has access to camera and it has |
If cross-origin.tld requests access it would not result in another prompt. We generally think this is good as it puts the blame with the top-level origin, who could already via Also, showing lots of prompts leads to dialog fatigue and showing prompts for third parties is generally confusing as they're pretty much an implementation detail of the site. |
Your scenario seems to only consider about top frame being evil, but there's also a possibility that top frame is vulnerable to HTML injection. Implementing Permission Delegation would allow HTML injection to delegate all permission top frame has, to cross-origin iframe. This means no matter how strong the CSP script-src mitigation is (to mitigate potential XSS), attacker can still steal all permissions. Which is bad. |
Hey Jun, thanks for your input. I don't really think this is the right forum to discuss this question (this repo is for discussing our official stance on external standards/proposals, not to challenge product/engineering decisions) and I'm not sure why you're confused about our position when we've just published an intent to ship a few days ago. I left an extensive explanation about our motivation on the dev-platform thread you also commented on https://groups.google.com/forum/#!topic/mozilla.dev.platform/BdFOMAuCGW8 It's probably a better idea to continue discussing there. Thanks! |
Based on the discussion above, I think it makes sense to close this. However, feel free to reopen (or ask us to -- not sure if you can directly) if you think an official Mozilla position on this is still needed beyond what's already been stated -- and with an explanation of why such a position is needed. |
Request for Mozilla Position on an Emerging Web Specification
Other information
Permission Delegation is not a standard or specification. But recently Firefox announced the intent to prototype Permission Delegation. I would like to know the Mozilla Position of Permission Delegation, and why would you like to do it (also why without a spec or a standard).
Most important points IMO to consider are:
iframe
's allow attribute is controlled and top-level frame requires that permission.The text was updated successfully, but these errors were encountered: