-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use profile-generate to replace outdated -Zprofile options #2282
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
cc @sylvestre would you like to take a look? This PR will address the failing CI on main. |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Snap workflow has been disable since it never works. https://github.com/mozilla/sccache/actions/runs/11701499882/job/32587729982?pr=2282
|
thanks ! |
I think we should revert this change because:
|
Hi, I reviewed all the documentation for Instrumentation-based Code Coverage and Profile-guided Optimization and now understand the mistake pointed out by @glandium. (Thank you for that!) I’m currently working on it and will restore everything back to normal. |
Related to mozilla/grcov#1240
I start this PR to fix the main branch's CI failure, but find out that we need to use profile-generate to replace outdated -Zprofile options.
Refer https://doc.rust-lang.org/rustc/profile-guided-optimization.html for more information.