Pass through --remap-path-prefix argument.
#2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2270 +/- ##
==========================================
- Coverage 30.91% 0 -30.92%
==========================================
Files 53 0 -53
Lines 20112 0 -20112
Branches 9755 0 -9755
==========================================
- Hits 6217 0 -6217
+ Misses 7922 0 -7922
+ Partials 5973 0 -5973 ☔ View full report in Codecov by Sentry. |
|
Bump Is there anybody else who could review my PR? |
|
Happy New Year! Who could have a look at this? |
|
sorry for the latency, could you please add a test ? thanks |
sylvestre
force-pushed
the
feature/remap-path-prefix
branch
from
9aebab5 to
a83b8f0
Compare
|
@sylvestre I can do that, but I first like to see #2269 being merged. |
ColinFinck
force-pushed
the
feature/remap-path-prefix
branch
from
a83b8f0 to
9f9df6f
Compare
|
@sylvestre I've added a test in 59a07ad |
|
merci! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see what's special about the
--remap-path-prefixargument that it was marked asTooHardand not just passed through.I'm changing it to
PassThroughhere. This change has worked in a local test.Please put my PR under scrutiny. This argument has been unsupported by sccache for a long time and it feels too simple to just change it to
PassThrough.