Fix syntax error for comments in array #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gbrail
reviewed
Oct 10, 2019
|
Thanks! I'm going to squash these two commits into one and merge them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #602
The error came from the fact that token type comment was not expected within array literal, so added that case to handle that error. Also added multiple test cases in
testsrc/org/mozilla/javascript/tests/ParserTest.javaunder the functiontestCommentInArray()to check all possible cases (single/multiple/no comments, and comments between literals)Please mention if something else needs to be fixed for this PR 😄