Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isProbablyReaderable returns true on a unreadable page #887

Open
tianzhich opened this issue Jun 29, 2024 · 0 comments
Open

isProbablyReaderable returns true on a unreadable page #887

tianzhich opened this issue Jun 29, 2024 · 0 comments

Comments

@tianzhich
Copy link
Contributor

I found that when a page contains multiple article tags, isProbablyReaderable will make a wrong judgment. Do we only need to check the first occurrence of the article tag?

For the website https://thebaffler.com/, it's strange that isProbablyReaderable returned true, but when I opened it with Firefox browser, the address bar did not show the reader icon. I'm not sure if Firefox is based on isProbablyReaderable for implementation.

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants