Fix a number of regressions/inefficiencies introduced by adding Scroll/Spread modes to the viewer (PR 9208 follow-up)#9832

Merged

timvandermeij merged 8 commits intomozilla:masterfrom Snuffleupagus:scrollMode-fixes

Jun 23, 2018

+124-48

Commits on Jun 23, 2018

[Regression] Remove instances of Element.classList.toggle() with *two* parameters, since browser support is limited
Snuffleupagus
committed
Remove all pages from the DOM at once, rather than using a loop, in PDFViewer._regroupSpreads
Snuffleupagus
committed
Add validation of the argument in the BaseViewer.{setScrollMode, setSpreadMode} methods
Snuffleupagus
committed
Move _updateScrollModeClasses from BaseViewer to PDFViewer
Snuffleupagus
committed
Refactor setScrollMode/setSpreadMode, in the viewer classes, such that they are no-ops in PDFSinglePageViewer instances
Snuffleupagus
committed
[Regression] Ensure that pre-rendering of the next/previous page works correctly in Presentation Mode, when horizontal scrolling was enabled
Snuffleupagus
committed
Don't attempt to modify the DOM and/or trigger rendering when changing Scroll/Spread modes without a PDF document being loaded
Snuffleupagus
committed
Simplify the _setScale call when changing Scroll modes
Snuffleupagus
committed