Drop trailing whitespace from test/unit/api_spec.js #19100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/unit/api_spec.js is the only JS file in the tree with trailing whitespace. Because `trim_trailing_whitespace = true` in .editorconfig, any editor supporting EditorConfig would trim whitespace when the file is changed, which results in test failures. This commit fixes the issue by trimming the trailing whitespace and adjusting the test expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/unit/api_spec.js is the only JS file in the tree with trailing whitespace. Because
trim_trailing_whitespace = truein .editorconfig, any editor supporting EditorConfig would trim whitespace when the file is changed, which results in test failures (e.g. at #19074 (comment)).This commit fixes the issue by trimming the trailing whitespace and adjusting the test expectations.
The test was originally introduced in #16559 and I don't expect any impact on the validity of the test.