From a92b38e71c6f68a28e29a65da5e699bad5f4f60e Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Wed, 28 Feb 2024 20:47:01 +0100 Subject: [PATCH] Inline the `HighlightEditor.#telemetryType` getter at its only call-site (PR 17748 follow-up) --- src/display/editor/highlight.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/display/editor/highlight.js b/src/display/editor/highlight.js index 8c8f010e6c71f..c6bbc463d6092 100644 --- a/src/display/editor/highlight.js +++ b/src/display/editor/highlight.js @@ -96,7 +96,7 @@ class HighlightEditor extends AnnotationEditor { get telemetryInitialData() { return { action: "added", - type: this.#telemetryType, + type: this.#isFreeHighlight ? "free_highlight" : "highlight", color: this._uiManager.highlightColorNames.get(this.color), thickness: this.#thickness, methodOfCreation: this.#methodOfCreation, @@ -116,10 +116,6 @@ class HighlightEditor extends AnnotationEditor { return { numberOfColors: data.get("color").size }; } - get #telemetryType() { - return this.#isFreeHighlight ? "free_highlight" : "highlight"; - } - #createOutlines() { const outliner = new Outliner(this.#boxes, /* borderWidth = */ 0.001); this.#highlightOutlines = outliner.getOutlines();