From 5f8957e8dfa966f6aa3e88c0b2b6f36b677fb190 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Thu, 15 Oct 2020 13:20:27 +0200
Subject: [PATCH] Fix the "should get form info when AcroForm is present"
 unit-test

The last unit-test didn't work correctly, since an error was thrown in `PDFDocument._hasOnlyDocumentSignatures` because the mocked `XRef`-instance wasn't actually being set correctly.

Also, updates the `XRefMock` to use `async` methods where appropriate.
---
 test/unit/document_spec.js | 9 +++++----
 test/unit/test_utils.js    | 8 ++++----
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/test/unit/document_spec.js b/test/unit/document_spec.js
index ba9968de9ee15..5224cbd1608dc 100644
--- a/test/unit/document_spec.js
+++ b/test/unit/document_spec.js
@@ -52,8 +52,9 @@ describe("document", function () {
     };
     const stream = new StringStream("Dummy_PDF_data");
 
-    function getDocument(acroForm) {
+    function getDocument(acroForm, xref = new XRefMock()) {
       const pdfDocument = new PDFDocument(pdfManager, stream);
+      pdfDocument.xref = xref;
       pdfDocument.catalog = { acroForm };
       return pdfDocument;
     }
@@ -144,18 +145,18 @@ describe("document", function () {
       kidsDict.set("Kids", [annotationRef]);
       const kidsRef = Ref.get(10, 0);
 
-      pdfDocument.xref = new XRefMock([
+      const xref = new XRefMock([
         { ref: annotationRef, data: annotationDict },
         { ref: kidsRef, data: kidsDict },
       ]);
 
       acroForm.set("Fields", [kidsRef]);
       acroForm.set("SigFlags", 3);
-      pdfDocument = getDocument(acroForm);
+      pdfDocument = getDocument(acroForm, xref);
       expect(pdfDocument.formInfo).toEqual({
         hasAcroForm: false,
         hasXfa: false,
-        fields: null,
+        fields: [kidsRef],
       });
     });
   });
diff --git a/test/unit/test_utils.js b/test/unit/test_utils.js
index 9171dd5c6afcf..635b78c93bbf5 100644
--- a/test/unit/test_utils.js
+++ b/test/unit/test_utils.js
@@ -93,8 +93,8 @@ class XRefMock {
     return this._map[ref.toString()];
   }
 
-  fetchAsync(ref) {
-    return Promise.resolve(this.fetch(ref));
+  async fetchAsync(ref) {
+    return this.fetch(ref);
   }
 
   fetchIfRef(obj) {
@@ -104,8 +104,8 @@ class XRefMock {
     return this.fetch(obj);
   }
 
-  fetchIfRefAsync(obj) {
-    return Promise.resolve(this.fetchIfRef(obj));
+  async fetchIfRefAsync(obj) {
+    return this.fetchIfRef(obj);
   }
 }