Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual indicator to show that there are embedded files #5961

Closed
jqnatividad opened this issue Apr 24, 2015 · 6 comments · Fixed by #7959
Closed

Visual indicator to show that there are embedded files #5961

jqnatividad opened this issue Apr 24, 2015 · 6 comments · Fixed by #7959

Comments

@jqnatividad
Copy link

Would be nice if there's a visual hint in the UI

@timvandermeij
Copy link
Contributor

Do you mean attachments? If so, do you have an example of how other PDF viewers do that?

@jqnatividad
Copy link
Author

Yes. I meant attachments.

I don't have an example, but one I can think of is showing the same paper clip icon already used in the sidebar next to the "Toggle Sidebar" icon when attachments are present.

Clicking on the "paper clip" would then go automatically to the "Attachments" tab.

@jqnatividad
Copy link
Author

An opendata proposal: PDF + Data = PDDF
http://blog.civicdashboards.com/2015/08/opendata-proposal-pdf-data-pddf/

Would love to get your thoughts...

@fbender
Copy link

fbender commented Nov 16, 2015

As proposed in #6644, I'd prefer a notification bar (similar to info when a PDF contains e.g. forms) with a button that opens the sidebar with the attachments view. This is obvious to the user and does not require new UX design or handling new items in the toolbar.

@jqnatividad
Copy link
Author

Hi @fbender ,
If by notification bar, you mean this:

pdf_form_example

then I agree that it is a more obvious way to show it to the reader. +1

@fbender
Copy link

fbender commented Nov 16, 2015

Yes indeed. Could also be used similarly for when forms are supported by PDF.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants