Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No delete button appears #17321

Closed
lapopm opened this issue Nov 23, 2023 · 1 comment
Closed

No delete button appears #17321

lapopm opened this issue Nov 23, 2023 · 1 comment

Comments

@lapopm
Copy link

lapopm commented Nov 23, 2023

Attach (recommended) or Link to PDF file here:
the demo template file

Configuration:

  • Web browser and its version: Chrome 119
  • Operating system and its version: Windows 11
  • PDF.js version: 4.0.189
  • Is a browser extension: No

Steps to reproduce the problem:
1. download prebuild version
2. I used the demo site to test the delete button after drawing, and it works
3. the delete button doesn't show when I put the prebuilt version into a folder in my project

What is the expected behavior? (add screenshot)
image

What went wrong? (add screenshot)
image

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

@Snuffleupagus
Copy link
Collaborator

Please compare the release date of https://github.com/mozilla/pdf.js/releases/tag/v4.0.189 with the merge date of #17243 (comment), and you should be able to answer this yourself :-)

Hence you'll simply have to wait for the next release, but please remember http://mozilla.github.io/pdf.js/getting_started/#introduction (emphasis mine):

The viewer is built on the display layer and is the UI for PDF viewer in Firefox and the other browser extensions within the project. It can be a good starting point for building your own viewer. However, we do ask if you plan to embed the viewer in your own site, that it not just be an unmodified version. Please re-skin it or build upon it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants