Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some data annotation(PopupElement) not showing #17215

Closed
jfl-tel opened this issue Nov 2, 2023 · 1 comment · Fixed by #17216
Closed

some data annotation(PopupElement) not showing #17215

jfl-tel opened this issue Nov 2, 2023 · 1 comment · Fixed by #17216
Assignees

Comments

@jfl-tel
Copy link

jfl-tel commented Nov 2, 2023

Attach (recommended) or Link to PDF file here:
Labo_2023_11_02.pdf

Configuration:

  • Web browser and its version: Firefox 119.0, Chrome 119 (previous version too)
  • Operating system and its version: All
  • PDF.js version: Latest, but I was able to pin point that this bug start occuring since v2.12.313 (with the rich text annotation support)
  • Is a browser extension: no

Steps to reproduce the problem:

  1. got to http://localhost:8888/web/viewer.html
  2. open the pdf attach in this issue
    ErreurShowingAnnotation

What is the expected behavior? (add screenshot)
ExpectedBehaviour

What went wrong? (add screenshot)
I did a fix, I can do a pr if you want, my opinion is that PopupElement show not add XfaLayer when enableXfa is false
src/display/annotation_layer.js
annotation_layer
Note: I have some pdf that comment are showing, this occur when contentsObj.str != richText.str in annotation_layer.js (line 2187)

https://github.com/mozilla/pdf.js/compare/master...jfl-tel:pdf.js:master

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

@calixteman calixteman self-assigned this Nov 2, 2023
@calixteman calixteman linked a pull request Nov 2, 2023 that will close this issue
@jfl-tel
Copy link
Author

jfl-tel commented Nov 2, 2023

Thanks a lot for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants