Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid DA for some text annotations which use a font not in DR #12294

Closed
calixteman opened this issue Aug 27, 2020 · 2 comments
Closed

Invalid DA for some text annotations which use a font not in DR #12294

calixteman opened this issue Aug 27, 2020 · 2 comments

Comments

@calixteman
Copy link
Contributor

Attach (recommended) or Link to PDF file here:
https://www.nta.go.jp/taxes/tetsuzuki/shinsei/annai/joyaku/annai/pdf2/250.pdf

This pdf contains some text annotations with (e.g. "Full name" field on the 1st page):

  • DA = "/MSGothic 8.5 Tf 0 g"
  • DR = << /Font << /KozMinPr6N-Regular 2867 0 R >> >>

When trying to print/save such a modified textfield then it isn't rendered correctly because the font is not found in DR.
According to the specs it seems that it's an error.
Since /MSGothic is present in Acroform::DR, then a way to fix this issue is to use a fallback dict when a resource is not available.

Do we want to fix this issue with such a workaround (I mean fix the DR: it tryed and it works well) ?
Or do we want to wait for a more general fix to handle chars which are not in the font coming from DA ?
Or anything else ?

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Aug 27, 2020

Since /MSGothic is present in Acroform::DR, then a way to fix this issue is to use a fallback dict when a resource is not available.

The correct solution, as mentioned in #12292 (review), is to first fix issue #12226 and then correctly (when getting this.fieldResources) merge the two different DR dictionaries.

@timvandermeij
Copy link
Contributor

Closing since this is fixed by #12361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@timvandermeij @Snuffleupagus @calixteman and others