-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pull request #12131 so it can be merged again #12152
Comments
yep, will do. shouldn't |
Ah, now I understand. |
In short, the |
I did find the root cause for the fact that the test failure was not reported on the bots, so I'll make a patch for that so that such problems don't go unnoticed again. |
@timvandermeij I've fixed the tests and pushed the branch. Should I issue a new pull request? |
Yes, indeed. We have just merged the fix for the test reporter so that such problems don't go unnoticed anymore in the future, so please rebase onto the current master branch and create a new PR. Thank you! |
Closing since the test reporter issue is fixed and there is a new PR for this now. |
It looks like the only problem that required us to do a revert of the patch is the fact that the unit tests in #12131 don't pass locally. However, they don't even run at all on the bots, hence we thought this was safe to merge given that all tests passed.
@timvandermeij Investigate why the bots did not run the test so this won't happen again.
@jsg2021 Could you improve the unit test so that we can try merging the patch again? Note the comment on the PR about what fails. In particular, we need to make sure that the tests work locally too; you can do that by running
gulp unittest
to test in the browser andgulp unittestcli
to test in Node.js. Both should pass in order for the patch to be merged again. Thanks!The text was updated successfully, but these errors were encountered: