Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

The "„" character is wrongly inserted in the sidebar instead of closing it when the "Alt+Shift+W" shortcut is pressed on Mac OS #780

Closed
Softvision-MariusComan opened this issue Mar 16, 2018 · 6 comments
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@Softvision-MariusComan
Copy link

[Affected versions]:

  • Firefox 58.0.2 and up

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • Have a Firefox profile with the latest version of the "Firefox Notes" add-on (3.1.0rc3) installed.
  • The "Firefox Notes" sidebar is opened

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and focus the sidebar.
  2. Press the "Alt+Shift+W" keys and observe the behavior.

[Expected result]:

  • The sidebar is closed.

[Actual result]:

  • The "„" character is inserted.

[Notes]:

  • The issue is reproducible with the TxP version of "Firefox Notes".
  • The issue is not reproducible on Windows and Linux.
  • Attached a screen recording of the issue:
    rec of the issue 3
@vladikoff
Copy link
Contributor

@cedricium I think we can fix this , can we bind to the shortcut combo from within notes to hide the pad?

@vladikoff
Copy link
Contributor

[Expected result]:

The sidebar is closed.

Agreed!

@cedricium
Copy link
Collaborator

@vladikoff should be doable using ckeditor's api, will go ahead and give this a shot.

Refs: https://docs.ckeditor.com/ckeditor5/latest/api/module_core_editingkeystrokehandler-EditingKeystrokeHandler.html

@vladikoff
Copy link
Contributor

@cedricium if you are looking at key strokes, see if you can get <tab> to tab #736

@vladikoff
Copy link
Contributor

@cedricium this might help ckeditor/ckeditor5#868 (comment) not sure if the code mentioned in that thread is real or what. TAB works on empty list items to indent those might be helpful

@cedricium
Copy link
Collaborator

@vladikoff opened a PR for this issue. Will take a look at the tab problem now 👍

@Softvision-MariusComan Softvision-MariusComan added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

3 participants