Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update clap-verbosity-flag requirement from 2.2 to 3.0 #2251

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 25, 2024

Updates the requirements on clap-verbosity-flag to permit the latest version.

Changelog

Sourced from clap-verbosity-flag's changelog.

[3.0.0] - 2024-11-20

Breaking Changes

  • Log support put behind the default log feature
  • LogLevel::default renamed to LogLevel::default_filter and now returns VerbosityFilter
  • Level and LevelFilter are moved into the log mod

Features

  • Add tracing feature with Verbosity::tracing_level and Verbosity::tracing_level_filter

[2.2.3] - 2024-11-16

Features

  • Add DebugLevel and TraceLevel for exploratory programming

[2.2.2] - 2024-09-26

Fixes

  • Resolve overflow issues

[2.2.1] - 2024-07-25

Compatibility

  • Raised MSRV to 1.74

[2.2.0] - 2024-02-14

Compatibility

  • Raised MSRV to 1.73

Features

  • Add is_present() to see if one of the flags is present on the command-line

[2.1.2] - 2024-01-16

Fixes

  • Don't pollute the CLIs help

[2.1.1] - 2023-12-15

Fixes

... (truncated)

Commits
  • 02d8ea5 chore: Release clap-verbosity-flag version 3.0.0
  • 9ae44a3 docs: Update changelog
  • 9118db6 Merge pull request #127 from joshka/jm/tracing-support
  • ed05b10 Merge pull request #126 from joshka/jm/log-optional
  • 53b0316 feat: Add support for tracing crate
  • 61c1bc6 feat!: Make log crate optional
  • ffffbe5 Merge pull request #125 from joshka/jm/verbosity-filter
  • e253647 feat!: Use VerbosityFilter instead of log::Level
  • 99c0859 chore: Release clap-verbosity-flag version 2.2.3
  • 9966b25 docs: Update changelog
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 25, 2024
@dependabot dependabot bot added the rust Pull requests that update Rust code label Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@larseggert larseggert added the bug Something isn't working label Nov 25, 2024
@dependabot dependabot bot force-pushed the dependabot/cargo/clap-verbosity-flag-3.0 branch from 1efaf9b to 12c6e03 Compare November 25, 2024 11:32
Updates the requirements on [clap-verbosity-flag](https://github.com/clap-rs/clap-verbosity-flag) to permit the latest version.
- [Changelog](https://github.com/clap-rs/clap-verbosity-flag/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap-verbosity-flag@v2.2.0...v3.0.0)

---
updated-dependencies:
- dependency-name: clap-verbosity-flag
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/clap-verbosity-flag-3.0 branch from 12c6e03 to a0847aa Compare November 26, 2024 09:04
@larseggert larseggert removed the bug Something isn't working label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (baae4f2) to head (55e8c6a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2251   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files         112      112           
  Lines       36567    36593   +26     
=======================================
+ Hits        34876    34901   +25     
- Misses       1691     1692    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert larseggert merged commit 5fe0c89 into main Nov 26, 2024
63 of 64 checks passed
@larseggert larseggert deleted the dependabot/cargo/clap-verbosity-flag-3.0 branch November 26, 2024 13:47
Copy link

Benchmark results

Performance differences relative to baae4f2.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.244 ns 99.606 ns 99.965 ns]
       change: [-0.4011% +0.1309% +0.7188%] (p = 0.64 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
12 (12.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.23 ns 117.65 ns 118.11 ns]
       change: [-0.3407% +0.0357% +0.4264%] (p = 0.86 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
2 (2.00%) low severe
1 (1.00%) low mild
3 (3.00%) high mild
12 (12.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.90 ns 117.43 ns 118.03 ns]
       change: [-1.1767% -0.3109% +0.4698%] (p = 0.50 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
4 (4.00%) low severe
2 (2.00%) low mild
7 (7.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.896 ns 98.084 ns 98.315 ns]
       change: [-0.2962% +0.5970% +1.4465%] (p = 0.18 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.91 ms 111.96 ms 112.01 ms]
       change: [-0.0528% +0.0143% +0.0851%] (p = 0.69 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
7 (7.00%) low mild
3 (3.00%) high mild

SentPackets::take_ranges: :green_heart: Performance has improved.
       time:   [5.5451 µs 5.7210 µs 5.9127 µs]
       change: [-96.562% -96.497% -96.430%] (p = 0.00 < 0.05)

Found 9 outliers among 100 measurements (9.00%)
6 (6.00%) high mild
3 (3.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.126 ms 27.160 ms 28.191 ms]
       change: [-8.5995% -3.2414% +2.3045%] (p = 0.25 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.314 ms 36.973 ms 38.636 ms]
       change: [-4.3028% +2.0900% +8.3528%] (p = 0.51 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [25.944 ms 26.759 ms 27.562 ms]
       change: [-6.0960% -2.2556% +2.0232%] (p = 0.29 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [41.113 ms 43.388 ms 45.730 ms]
       change: [-9.6852% -2.9271% +4.2095%] (p = 0.41 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.
       time:   [918.19 ms 927.35 ms 936.71 ms]
       thrpt:  [106.76 MiB/s 107.83 MiB/s 108.91 MiB/s]
change:
       time:   [-0.3232% +1.1100% +2.5924%] (p = 0.15 > 0.05)
       thrpt:  [-2.5269% -1.0978% +0.3243%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [318.68 ms 322.18 ms 325.78 ms]
       thrpt:  [30.696 Kelem/s 31.039 Kelem/s 31.379 Kelem/s]
change:
       time:   [-0.4596% +0.9779% +2.5235%] (p = 0.21 > 0.05)
       thrpt:  [-2.4614% -0.9684% +0.4617%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.
       time:   [33.690 ms 33.907 ms 34.141 ms]
       thrpt:  [29.291  elem/s 29.492  elem/s 29.682  elem/s]
change:
       time:   [-0.3555% +0.4836% +1.2731%] (p = 0.26 > 0.05)
       thrpt:  [-1.2571% -0.4813% +0.3567%]

Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) low mild
5 (5.00%) high mild
2 (2.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected.
       time:   [1.6189 s 1.6386 s 1.6591 s]
       thrpt:  [60.274 MiB/s 61.028 MiB/s 61.771 MiB/s]
change:
       time:   [-1.5104% +0.2323% +1.9415%] (p = 0.80 > 0.05)
       thrpt:  [-1.9045% -0.2317% +1.5336%]

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms]
gquiche gquiche 1504 571.3 ± 113.9 508.4 852.5
neqo gquiche reno on 1504 796.5 ± 81.5 726.7 974.4
neqo gquiche reno 1504 842.0 ± 148.6 748.8 1201.5
neqo gquiche cubic on 1504 800.8 ± 87.1 737.7 978.9
neqo gquiche cubic 1504 782.3 ± 50.4 748.0 921.4
msquic msquic 1504 199.8 ± 101.2 104.6 355.1
neqo msquic reno on 1504 303.0 ± 132.0 209.8 630.0
neqo msquic reno 1504 296.8 ± 78.4 209.3 403.9
neqo msquic cubic on 1504 213.2 ± 11.1 197.8 230.3
neqo msquic cubic 1504 282.1 ± 100.7 214.5 493.6
gquiche neqo reno on 1504 728.3 ± 120.3 568.1 942.4
gquiche neqo reno 1504 707.5 ± 154.1 557.9 1079.7
gquiche neqo cubic on 1504 705.4 ± 93.2 580.6 853.0
gquiche neqo cubic 1504 707.1 ± 109.6 571.9 940.9
msquic neqo reno on 1504 479.1 ± 10.9 456.4 488.4
msquic neqo reno 1504 536.2 ± 77.3 479.9 726.4
msquic neqo cubic on 1504 489.9 ± 14.0 471.9 506.7
msquic neqo cubic 1504 545.5 ± 96.3 480.3 742.2
neqo neqo reno on 1504 538.9 ± 50.5 478.0 660.8
neqo neqo reno 1504 519.2 ± 78.6 458.6 728.4
neqo neqo cubic on 1504 582.5 ± 85.8 509.2 754.1
neqo neqo cubic 1504 544.2 ± 38.3 488.2 592.4

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant