-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cocoapods support #310
Comments
How would that support look like? The library has a C interface, but I guess a proper library for Cocoa should have an interface compatible with ObjC and/or Swift best practices. If you'd like to implement a higher-level ObjC or Swift wrapper for libjpeg, that'd be great. |
Thanks for your quick answer @kornelski. Couldn't agree more. Since C is interoperable with Objective-C, I'd suggest first and foremost defining a As you've mentioned, It would then open the door for a higher-level Objective-C/Swift compatible framework that exposes idiomatic platform APIs depending on mozjpeg's C library through CP. In practice, adding support for CP simply requires adding a I've got a working podspec locally - so happy to push a PR if that's ok with you and get into more details there!? |
Yes, great! I'm happy to add a podspec. |
It's live https://cocoapods.org/pods/mozjpeg ! One last thing - could I ask you to register on cocoapods trunk so we can have shared ownership of the pod? To do so, you'd simply have to do three things:
FYI, when releasing a new update, the only required thing will be to update the version number / tag in the podspec and run from the root of the repo:
Cheers, Kornel! |
Hi,
First of all, thanks for the great library!
Would you be open in accepting a PR adding cocoapods support for Mozjpeg? Cocoapods is a dependency manager for iOS projects which would make the library's integration a no brainer and should only require adding a single file to the repo.
Thanks!
The text was updated successfully, but these errors were encountered: