Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg-config dependency missing #135

Closed
ghost opened this issue Dec 15, 2014 · 6 comments
Closed

pkg-config dependency missing #135

ghost opened this issue Dec 15, 2014 · 6 comments
Milestone

Comments

@ghost
Copy link

ghost commented Dec 15, 2014

Seems like at least one other person had the same problem:
#99
So a line in https://github.com/mozilla/mozjpeg/blob/master/BUILDING.txt would be nice.
Thanks :)

@kornelski
Copy link
Member

Ideally the pkg-config dependency itself should be optional (just don't build PNG when pkg-config is missing), but my autotools-fu is to weak for this.

@bdaehlie bdaehlie added this to the v3.0 milestone Dec 16, 2014
@dwbuiten
Copy link
Contributor

That's kind of contrary to the point of autotools. Users aren't supposed to be generating configure in the first place. See #86.

@kornelski
Copy link
Member

I'm not saying users should be generating configure, but that configure file you generate should ideally work with or without pkg-config.

If there's pkg-config and libpng - configure PNG. If either one is missing - skip PNG support.

Is that possible?

@bdaehlie
Copy link
Contributor

I think we should resolve this by shipping a tarball with a pre-generated configure. I'll file a bug on that. We'll need to update our build instructions to include from-git and from-tarball instructions.

@dwbuiten
Copy link
Contributor

I'm not saying users should be generating configure, but that configure file you generate should ideally work with our without pkg-config.

That is already the case. The problem only happens when configure is incorrectly generated due to the pkg-config macros being missing.

@bdaehlie
Copy link
Contributor

Release now includes a generated configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants