Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to use local bulma instead of jsdelivr CDN #1079

Open
legoktm opened this issue Jul 20, 2023 · 1 comment · May be fixed by #1086
Open

Option to use local bulma instead of jsdelivr CDN #1079

legoktm opened this issue Jul 20, 2023 · 1 comment · May be fixed by #1086

Comments

@legoktm
Copy link

legoktm commented Jul 20, 2023

Hi, thanks for developing grcov!

On https://doc.wikimedia.org we have a pretty restrictive CSP that only allows local/self-hosted resources for both privacy and security reasons (e.g. a broken report). Would it be possible to bundle any necessary resources with grcov so they don't need to be loaded from a remote site? This would also be nice for offline usage.

See for example how a PHPUnit report bundles bootstrap.
@calixteman
Copy link
Collaborator

We could just read an env variable which will contain the path of the css file and fallback on the url.
That said the bulma version is pinpointed:

grcov/src/html.rs

Line 75 in 322fc39

static BULMA_VERSION: &str = "0.9.1";

and we should probably have the url in the Cargo file.

legoktm added a commit to legoktm/grcov that referenced this issue Aug 2, 2023
@legoktm
Bundle bulma CSS
7770c22 
To support restricted or offline environments, bundle the bulma CSS with
grcov instead of loading it from the jsdelivr CDN.

HTML reports will now create `bulma.min.css` in the root directory and
relatively reference it in all the HTML files.

Fixes mozilla#1079.
@legoktm legoktm linked a pull request Aug 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bundle bulma CSS legoktm/grcov
2 participants
@legoktm @calixteman