Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_mac fails when enabled #45

Open
mstange opened this issue Aug 3, 2022 · 3 comments
Open

test_mac fails when enabled #45

mstange opened this issue Aug 3, 2022 · 3 comments

Comments

@mstange
Copy link
Collaborator

mstange commented Aug 3, 2022

% cargo test
    Finished test [unoptimized + debuginfo] target(s) in 0.04s
     Running unittests src/main.rs (target/debug/deps/fix_stacks-a64e346390a79ade)

running 8 tests
test tests::test_regex ... ok
test tests::test_linux_breakpad ... ok
test tests::test_files ... ok
test tests::test_linux_breakpad_fallback ... ok
test tests::test_mac ... FAILED
test tests::test_linux ... ok
test tests::test_windows_breakpad ... ok
test tests::test_windows ... ok

failures:

---- tests::test_mac stdout ----
thread 'tests::test_mac' panicked at 'assertion failed: `(left == right)`
  left: `"#00: main (/Users/njn/moz/fix-stacks/tests/mac-normal.c:17)"`,
 right: `"#00: main (tests/mac-multi + 0xd70)"`', src/tests.rs:244:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    tests::test_mac

test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.58s

error: test failed, to rerun pass '--bin fix-stacks'
@mstange
Copy link
Collaborator Author

mstange commented Aug 3, 2022

This is due to getsentry/symbolic#471.

@mstange
Copy link
Collaborator Author

mstange commented Aug 3, 2022

Specifically, tests/mac-normal.o has a function main at address 0x0, and we fail to look up line information for it because symbolic's line parsing ignores line rows at address 0x0.

@mstange mstange changed the title test_mac fails test_mac fails when enabled Aug 5, 2022
@mstange
Copy link
Collaborator Author

mstange commented Aug 5, 2022

I've disabled the test in #48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant