Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Remove card rendering #502

Closed
ianb opened this issue Oct 25, 2019 · 1 comment
Closed

Remove card rendering #502

ianb opened this issue Oct 25, 2019 · 1 comment
Milestone
Code Quality

Comments

@ianb
Copy link
Contributor

ianb commented Oct 25, 2019

We aren't including ddg cards anymore, and should remove that code from popup.html and ui.js.
@ianb ianb added this to the Stretch milestone Oct 25, 2019
ianb pushed a commit that referenced this issue Nov 1, 2019
@jenniferharmon @ianb
React and most popup functionality (#507)
808f57c 
* Fix #491, convert the popup to use React
* Remove popup.js and add to gitignore. It is auto-generated by script "npm run build:jsx"
* Fixes Issue #502 Remove card rendering
@ianb
Copy link
Contributor Author

ianb commented Dec 12, 2019

I believe @jenniferharmon fixed this in the PR that rewrote it as React

@ianb ianb closed this as completed Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Code Quality
Development

No branches or pull requests
1 participant
@ianb