Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Review matchers for plurals #496

Closed
ianb opened this issue Oct 24, 2019 · 0 comments · Fixed by #501
Closed

Review matchers for plurals #496

ianb opened this issue Oct 24, 2019 · 0 comments · Fixed by #501

Comments

@ianb
Copy link
Contributor

ianb commented Oct 24, 2019

We saw one specific example where someone said next results instead of next result and it didn't match.

I'm tempted to add (s) to the syntax, or generally word(optional), so we can do next result(s) instead of next (result | results)
ianb added a commit that referenced this issue Oct 25, 2019
@ianb
Refine intent matches
8c3ec27 
This tries to improve and expand on several intent matches. Fixes #495. Fixes #496.

Also adds test: examples, that aren't displayed in the popup, but are used in the intent viewer as tests of a sort.
@ianb ianb mentioned this issue Oct 25, 2019
Merged
@ianb ianb closed this as completed in #501 Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine intent matches mozilla-extensions/firefox-voice
1 participant
@ianb