Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

"Unpause" command will play audio from previous channel video and let current Youtube video be paused #407

Open
alexandra-martin opened this issue Oct 11, 2019 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alexandra-martin
Copy link

Prerequisites:

Mic and autoplay permissions are enabled.
Make sure that when making the Youtube "Play" command, the result opens a Youtube channel.

STR:

  1. Use the shortcut or click on the mic icon from the browser toolbar.
  2. Say or write a Youtube "Play" command, e.g. "Play Green Day on Youtube".
  3. Pause the playing video from the channel and select another video from the page to be displayed in the tab.
  4. Pause the video and use the shortcut or click on the mic icon from the browser toolbar.
  5. Say or write an "Unpause" command.

Expected result:

The Youtube video is unpaused.

Actual result:

The audio from the channel video is playing but the current Youtube video is paused.

Notes:

Reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

9

@alexandra-martin alexandra-martin added the bug Something isn't working label Oct 11, 2019
@ianb ianb closed this as completed in ae3fde2 Oct 14, 2019
ianb added a commit that referenced this issue Oct 14, 2019
Fix #407, do not let unpause pause a YouTube video
@alexandra-martin
Copy link
Author

The bug is still reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

2

@ianb ianb assigned ianb and unassigned ianb Oct 21, 2019
@ianb ianb added this to the Backlog milestone Oct 25, 2019
@OliviaRuyinZhang
Copy link
Contributor

Can i give this one a shot? It looks like the "pause" and "unpause" intent would get confused when we have two tabs both playing youtube videos the same time

@alexandra-martin
Copy link
Author

@ianb or @awallin can help you out with issues assignment.

@ianb
Copy link
Contributor

ianb commented Mar 12, 2020

@OliviaRuyinZhang Sure, you are assigned!

@alexandra-martin
Copy link
Author

Verified on Mac 10.14 and Win10x64 with Firefox Nightly 76.0a1 (2020-03-13).
Currently the issue is not reproducing anymore, probably due to #1244 that fixed #422.

6

5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants