Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

"Look up Spotify on Twitter" will open Spotify tab instead of Twitter #344

Closed
alexandra-martin opened this issue Sep 30, 2019 · 2 comments
Closed
Assignees
Labels
bug Something isn't working Verified Fix was validated by QA
Milestone

Comments

@alexandra-martin
Copy link

alexandra-martin commented Sep 30, 2019

Prerequisites:

Mic permissions are enabled.

STR:

  1. Use the shortcut or click on the mic icon from the browser toolbar.
  2. Say or write a "Look up" command, e.g. "Look up Spotify on Gmail", "Look up Spotify on Twitter", or "Look up Spotify on Instagram".

Expected result:

Following the examples given, Gmail, Twitter, or Instagram open in a new tab with search results for Spotify.

Actual result:

Spotify opens in a new tab with search results for "on Gmail", "on Twitter" or "on Instagram".

Notes:

Reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).
Similar commands like, "Look up Goodreads on Twitter", "Look up Youtube on Twitter" etc. will open Goodreads and Youtube tabs instead of the Twitter tab.

81

@alexandra-martin alexandra-martin added the bug Something isn't working label Sep 30, 2019
@ianb
Copy link
Contributor

ianb commented Oct 3, 2019

The intent that's being matched here is (do a |) (search | query | look up | lookup | look on | look for) (my |) [service:serviceName] (for | for the |) [query]

So it's matching look up [service] [query]. I'm not sure if this is a good intent match? Maybe we should break that up.

@ianb ianb added this to the Internal beta milestone Oct 3, 2019
@ianb ianb self-assigned this Oct 3, 2019
@ianb ianb closed this as completed in c532f31 Oct 3, 2019
ianb added a commit that referenced this issue Oct 3, 2019
Fix #344, make 'look for' intent matchers more specific
ianb added a commit that referenced this issue Oct 3, 2019
@alexandra-martin
Copy link
Author

Verified on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

87

@alexandra-martin alexandra-martin added the Verified Fix was validated by QA label Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Verified Fix was validated by QA
Projects
None yet
Development

No branches or pull requests

2 participants