Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

"Google images of ... " command doesn't display images in Google Images #326

Closed
alexandra-martin opened this issue Sep 25, 2019 · 5 comments
Closed

"Google images of ... " command doesn't display images in Google Images #326

alexandra-martin opened this issue Sep 25, 2019 · 5 comments
Assignees
@ianb
Labels
bug Something isn't working good first issue Good for newcomers Verified Fix was validated by QA
Milestone
External beta

Comments

@alexandra-martin
Copy link

Prerequisites:

Mic permissions are enabled.

STR:

  1. Click on the mic icon from the browser toolbar.
  2. Say or write "Google images of lions".

Expected result:

A new tab opens with results in Google Images.

Actual result:

A new tab opens with results in Google All.

Notes:

Reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

65
@alexandra-martin alexandra-martin added the bug Something isn't working label Sep 25, 2019
@ianb ianb added the good first issue Good for newcomers label Sep 26, 2019
@ianb ianb added this to the External beta milestone Sep 26, 2019
@ianb
Copy link
Contributor

ianb commented Sep 26, 2019

We need to put in a special intent and intent matcher for "google images" so that "google [query]" doesn't catch this.

@lozinska
Copy link

Hello there! I'm new to GitHub and would like to work on this issue

@ianb ianb self-assigned this Oct 4, 2019
@ianb
Copy link
Contributor

ianb commented Oct 7, 2019

@lozinska Oh, I'm sorry, I only noticed your comment when I was putting in a fix for this!

@ianb
Copy link
Contributor

ianb commented Oct 7, 2019

I've added these matchers:

    google images (of |) [query] [service=images]
    search images (for |) [query] [service=images]
    images of [query] [service=images]

@ianb ianb closed this as completed in 7f178dc Oct 7, 2019
ianb added a commit that referenced this issue Oct 7, 2019
@ianb
Merge pull request #384 from mozilla/google-images
3fac1ff 
Fix #326, support specific google images questions
@alexandra-martin
Copy link
Author

Verified on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit) for all three matchers.

117

@alexandra-martin alexandra-martin added the Verified Fix was validated by QA label Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianb ianb

Labels
bug Something isn't working good first issue Good for newcomers Verified Fix was validated by QA
Projects
None yet
Milestone
External beta
Development

No branches or pull requests
3 participants
@ianb @lozinska @alexandra-martin