Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

[read] Give readable error if page cannot go into reader mode #311

Closed
ianb opened this issue Sep 23, 2019 · 0 comments
Closed

[read] Give readable error if page cannot go into reader mode #311

ianb opened this issue Sep 23, 2019 · 0 comments
Labels
good first issue Good for newcomers
Milestone
Internal beta

Comments

@ianb
Copy link
Contributor

ianb commented Sep 23, 2019

We should catch the error and show it to the user, instead of mostly-silently failing.

We might also want to "force" reader mode. Maybe one of these extensions does that? At least I recall seeing some extension use that technique. This page is an example of one that might need forcing.
@ianb ianb added this to the Internal beta milestone Sep 26, 2019
@ianb ianb added the good first issue Good for newcomers label Sep 26, 2019
@ianb ianb closed this as completed in b9d0bd8 Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Internal beta
Development

No branches or pull requests
1 participant
@ianb