Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Remove Hulu bang search #289

Closed
alexandra-martin opened this issue Sep 23, 2019 · 2 comments
Closed

Remove Hulu bang search #289

alexandra-martin opened this issue Sep 23, 2019 · 2 comments
Assignees
Labels
bug Something isn't working Verified Fix was validated by QA

Comments

@alexandra-martin
Copy link

Prerequisites:

Mic permissions are enabled.
Have an active Hulu account and be logged in beforehand.

STR:

  1. Click on the mic icon from the browser toolbar.
  2. Say or write a "Look up" command for Hulu, e.g. "Look up American Horror Story on Hulu".

Expected result:

Hulu opens in a new tab with search results for "American Horror Story".

Actual result:

Hulu opens in a new tab and displays the search page, but there is no indication that "American Horror Story" is searched, only in the URL.

Notes:

Reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).
Writing "American Horror Story" in the website's search field will display results for the term searched.

56

@alexandra-martin alexandra-martin added the bug Something isn't working label Sep 23, 2019
@ianb
Copy link
Contributor

ianb commented Sep 26, 2019

I'm guessing they've changed their URL scheme, and DDG hasn't updated the bang. @awallin is going to submit a fix. For now we should remove (or comment out) the bang in our code.

@ianb ianb modified the milestones: Backlog, Internal beta Sep 26, 2019
@ianb ianb modified the milestones: Internal beta, Search/Nav Epic Oct 25, 2019
@ianb ianb changed the title "Look up" command for Hulu will not display results for the term searched Remove Hulu Oct 25, 2019
@ianb ianb changed the title Remove Hulu Remove Hulu bang search Oct 25, 2019
@ianb ianb self-assigned this Oct 31, 2019
@ianb ianb closed this as completed in a52b7ae Nov 6, 2019
ianb added a commit that referenced this issue Nov 6, 2019
@alexandra-martin
Copy link
Author

Verified on Mac 10.14.6 and Win10x64 with Firefox Nightly 72.0a1 (64-bit).

3

@alexandra-martin alexandra-martin added the Verified Fix was validated by QA label Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Verified Fix was validated by QA
Projects
None yet
Development

No branches or pull requests

3 participants