Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

"Look up ... on maps" command will not open Google Maps #288

Closed
alexandra-martin opened this issue Sep 23, 2019 · 3 comments
Closed

"Look up ... on maps" command will not open Google Maps #288

alexandra-martin opened this issue Sep 23, 2019 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers Verified Fix was validated by QA
Milestone

Comments

@alexandra-martin
Copy link

Prerequisites:

Mic permissions are enabled.

STR:

  1. Click on the mic icon from the browser toolbar.
  2. Say or write a "Look up" command for Google Maps, e.g. "Look up Denver on maps".

Expected result:

Google Maps opens in a new tab with the map of Denver.

Actual result:

A Google search result for "maps denver" is shown.

Notes:

Reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).
Saying or writing "Look up Denver on Google Maps" will open Google Maps in a new tab and the map of Denver is displayed (second gif).
I saw that in the written code, the service "google maps" has the "gmap" alias, while the service "maps" has "google maps" as alias, maybe the bug is reproduced because the services don't have the same alias.

54

55

@alexandra-martin alexandra-martin added the bug Something isn't working label Sep 23, 2019
@ianb
Copy link
Contributor

ianb commented Sep 26, 2019

This may be an intent parser error, where we aren't resolving or parsing this as Google Maps. We want to fix this.

@ianb ianb added this to the Internal beta milestone Sep 26, 2019
@ianb ianb added the good first issue Good for newcomers label Sep 26, 2019
@KhushilMistry
Copy link
Contributor

Hey, I want to work on this issue. I will submit a PR in a while.

@ianb ianb closed this as completed in ea4ee7c Oct 11, 2019
ianb added a commit that referenced this issue Oct 11, 2019
Fix #288, Look up on maps command will open Google Maps
@alexandra-martin
Copy link
Author

Verified on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

1

@alexandra-martin alexandra-martin added the Verified Fix was validated by QA label Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers Verified Fix was validated by QA
Projects
None yet
Development

No branches or pull requests

3 participants