Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

"Look up" command on Shazam displays blank page #287

Closed
alexandra-martin opened this issue Sep 23, 2019 · 4 comments · Fixed by #413
Closed

"Look up" command on Shazam displays blank page #287

alexandra-martin opened this issue Sep 23, 2019 · 4 comments · Fixed by #413
Assignees
@KhushilMistry
Labels
bug Something isn't working good first issue Good for newcomers Verified Fix was validated by QA
Milestone
Internal beta

Comments

@alexandra-martin
Copy link

Prerequisites:

Mic permissions are enabled.

STR:

  1. Click on the mic icon from the browser toolbar.
  2. Say or write a "Look up" command, e.g. "Look up Green Day on Shazam".

Expected result:

Shazam opens in a new tab with search results for Green Day.

Actual result:

Shazam opens in a new tab and the page is blank.

Notes:

Reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1.
Reproduced also with the "Search Green Day on Shazam" command.

52
@alexandra-martin alexandra-martin added the bug Something isn't working label Sep 23, 2019
@awallin
Copy link
Contributor

awallin commented Sep 23, 2019

I get the same result. It's unclear what the correct URL construction for a search on Shazam should be as the search functionality is displayed in a popup.

Might want to remove this bang?

@ianb
Copy link
Contributor

ianb commented Sep 26, 2019

Yes, let's delete

@ianb ianb added the good first issue Good for newcomers label Sep 26, 2019
@ianb ianb added this to the Internal beta milestone Sep 26, 2019
@KhushilMistry
Copy link
Contributor

I am working on this. I will submit a PR in a while.

KhushilMistry added a commit to KhushilMistry/firefox-voice that referenced this issue Oct 11, 2019
@KhushilMistry
Fix mozilla-extensions#287, remove Shazam from service list
ed3b50e
@KhushilMistry KhushilMistry mentioned this issue Oct 11, 2019
Merged
@ianb ianb closed this as completed in #413 Oct 14, 2019
ianb added a commit that referenced this issue Oct 14, 2019
@ianb
Merge pull request #413 from KhushilMistry/287-remove-shazam
bbb45fc 
Fix #287, remove Shazam from the service list
@alexandra-martin
Copy link
Author

Verified on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

7

@alexandra-martin alexandra-martin added the Verified Fix was validated by QA label Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KhushilMistry KhushilMistry

Labels
bug Something isn't working good first issue Good for newcomers Verified Fix was validated by QA
Projects
None yet
Milestone
Internal beta
Development

Successfully merging a pull request may close this issue.

Fix #287, remove Shazam from the service list KhushilMistry/firefox-voice
4 participants
@ianb @awallin @KhushilMistry @alexandra-martin