Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Saying "Read this page" 2 times will disable text to speech mode #260

Closed
alexandra-martin opened this issue Sep 17, 2019 · 3 comments
Closed
Labels
bug Something isn't working Verified Fix was validated by QA
Milestone

Comments

@alexandra-martin
Copy link

Prerequisites:

Have mic permissions enabled.
Have a opened page supporting text to speech mode, e.g. a New York Times article.

STR:

  1. Click on the mic icon from the browser's toolbar.
  2. Say the "Read this page" command then wait for the action to be made.
  3. Repeat steps 1 and 2.

Expected result:

Page remains in text to speech mode.

Actual result:

Text to speech mode is disabled.

Notes:

Reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

24

@alexandra-martin alexandra-martin added the bug Something isn't working label Sep 17, 2019
@ianb ianb added this to the Backlog milestone Sep 18, 2019
@ianb
Copy link
Contributor

ianb commented Sep 18, 2019

We might have a bug for this as well, as it was a known limitation when I reimplemented the read intent and I thought I made a followup (but I'm not able to find it now)

@alexandra-martin
Copy link
Author

Update:
Text to speech mode is disabled also after saying the "Read" command two times.
Reproduced on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

48

ianb added a commit that referenced this issue Sep 27, 2019
Also fix #260, 'read' no longer toggles, but only starts reading. Also fix #152, you can stop reading (with 'stop reading') a page that was started manually
@ianb ianb closed this as completed in 33feb10 Sep 27, 2019
@alexandra-martin
Copy link
Author

Verified on Mac 10.14.6 and Win10x64 with Firefox Nightly 71.0a1 (64-bit).

77

@alexandra-martin alexandra-martin added the Verified Fix was validated by QA label Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Verified Fix was validated by QA
Projects
None yet
Development

No branches or pull requests

2 participants