Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Make "stop" work on narration started without Voice #152

Closed
ianb opened this issue Aug 28, 2019 · 1 comment
Closed

Make "stop" work on narration started without Voice #152

ianb opened this issue Aug 28, 2019 · 1 comment
Milestone
Code Quality

Comments

@ianb
Copy link
Contributor

ianb commented Aug 28, 2019

Right now the stop intent only works on narration pages that were started by saying read. It should work even if you clicked your way to reading.

This is a followup to #150, and should happen in the intents.read.stopReading() function.
@ianb ianb added this to the Stretch milestone Sep 3, 2019
@ianb
Copy link
Contributor Author

ianb commented Sep 27, 2019

Note that stop no longer stops the reading (though a future change will implement a generic stop) but now stop reading explicitly stops narration and only narration.

ianb added a commit that referenced this issue Sep 27, 2019
@ianb
Fix #307, make read intent use content script handlers
a37324e 
Also fix #260, 'read' no longer toggles, but only starts reading. Also fix #152, you can stop reading (with 'stop reading') a page that was started manually
@ianb ianb closed this as completed in 33feb10 Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Code Quality
Development

No branches or pull requests
1 participant
@ianb