Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Add cancel/nevermind intents #104

Closed
ianb opened this issue Aug 14, 2019 · 4 comments
Closed

Add cancel/nevermind intents #104

ianb opened this issue Aug 14, 2019 · 4 comments
Assignees
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Aug 14, 2019

If you just say "cancel" right now it searches for cancel.

  • Cancel
  • Stop
  • Nevermind
@awallin
Copy link
Contributor

awallin commented Aug 14, 2019

There may be conflicts around "stop" (maybe "cancel") when playing media. E.g. does the user mean "stop playing the audio" or asking the assistant to stop trying to fulfill the request.

@jcambre
Copy link
Contributor

jcambre commented Aug 14, 2019

I'm also inclined to put this into the UI (e.g. cancelling upon ESC, clicking an X button, dismissing the popup)

@ianb
Copy link
Contributor Author

ianb commented Aug 14, 2019

Agreed, stop is problematic, and probably shouldn't be on this list. But searching for cancel is definitely the wrong thing! Searching for "this is a test" is also probably the wrong thing (since I've been doing that a lot too ;)

@ianb ianb added this to the Internal beta milestone Aug 22, 2019
@ianb
Copy link
Contributor Author

ianb commented Aug 22, 2019

It would be nice if "cancel" could stop narration as well. Maybe we should add this to the intent API.

@ianb ianb changed the title Add cancel/stop intents Add cancel/nevermind intents Oct 3, 2019
@ianb ianb self-assigned this Oct 3, 2019
@ianb ianb closed this as completed in 2f5c190 Oct 3, 2019
ianb added a commit that referenced this issue Oct 3, 2019
Fix #104, add cancel/nevermind intents
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants