Add FORCE_SENTRY option for local development

mozilla-extensions · Oct 3, 2019 · fd7e9b4 · fd7e9b4
1 parent 6a2ff9e
commit fd7e9b4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/extension/buildSettings.js.ejs b/extension/buildSettings.js.ejs
@@ -6,5 +6,5 @@ this.buildSettings = {
   buildTime: <%= buildTime %>,
   backgroundTabRecorder: <%= !env.FOREGROUND %>,
   channel: "<%- env.INSTALL_CHANNEL || "unknown" %>",
-  sentryDsn: <%= env.NO_SENTRY ? null : env.SENTRY_DSN || "https://[email protected]/458" %>,
+  sentryDsn: <%= (env.NO_SENTRY && !env.FORCE_SENTRY) ? null : env.SENTRY_DSN || "https://[email protected]/458" %>,
 };
diff --git a/extension/catcher.js b/extension/catcher.js
@@ -4,6 +4,8 @@ this.catcher = (function() {
   const exports = {};
   const hostname = location.hostname;
 
+  // Note Sentry is usually enabled for live builds and disabled for local development
+  // to test Sentry locally use FORCE_SENTRY=1 npm start
   const activated = (exports.sentryActivated = !!buildSettings.sentryDsn);
 
   function fixUrl(u) {

diff --git a/extension/manifest.json.ejs b/extension/manifest.json.ejs
@@ -24,7 +24,7 @@
       "util.js",
       "buildSettings.js",
       "log.js",
-      <% if (! env.NO_SENTRY) { %>
+      <% if (! (env.NO_SENTRY && !env.FORCE_SENTRY)) { %>
       "js/vendor/sentry.js",
       <% } %>
       "catcher.js",