Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mtdata datasets fail because of long name #654

Closed
Tracked by #311
eu9ene opened this issue May 30, 2024 · 4 comments
Closed
Tracked by #311

Some mtdata datasets fail because of long name #654

eu9ene opened this issue May 30, 2024 · 4 comments
Labels
taskcluster Issues related to the Taskcluster implementation of the training pipeline

Comments

@eu9ene
Copy link
Collaborator

eu9ene commented May 30, 2024

It's related to the Taskcluster limitation of the label size (256 characters)

Example:

- mtdata_ELRC-convention_against_torture_other_cruel_inhuman_or_degrading_treatment_or_punishment_united_nations-1-ell-eng
@eu9ene eu9ene added the taskcluster Issues related to the Taskcluster implementation of the training pipeline label May 30, 2024
@bhearsum
Copy link
Collaborator

We should fix this by shortening the name somehow. We could run these names through some function that guarantees:

  • a short enough name
  • uniqueness

@bhearsum
Copy link
Collaborator

@eu9ene, @gregtatum - how would you feel about taking the first N characters of datasets, truncating the rest, and adding an md5 (or similar) hash of the full dataset to the end? This would keep the datasets reasonable readable and ensure uniqueness without needing to maintain some sort of lookup table.

@eu9ene
Copy link
Collaborator Author

eu9ene commented Jun 28, 2024

Sounds good. I don't think the label is particularly important for training datasets. For evals, we use short dataset names.

@bhearsum
Copy link
Collaborator

Oh, I see we're already doing something similar after #611 - I'll extend that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
taskcluster Issues related to the Taskcluster implementation of the training pipeline
Projects
None yet
Development

No branches or pull requests

2 participants