Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation fails on a pre-trained backward model #628

Closed
Tracked by #311
eu9ene opened this issue May 23, 2024 · 3 comments · Fixed by #781
Closed
Tracked by #311

Evaluation fails on a pre-trained backward model #628

eu9ene opened this issue May 23, 2024 · 3 comments · Fixed by #781
Assignees
Labels
bug Something is broken or not correct taskcluster Issues related to the Taskcluster implementation of the training pipeline

Comments

@eu9ene
Copy link
Collaborator

eu9ene commented May 23, 2024

https://firefox-ci-tc.services.mozilla.com/tasks/CEUR_rZ1Qty22JNz3JC-mw

We shouldn't run evals for the pre-trained models though. It wasn't the case before, so something got broken in training continuation.

This is not critical as it does not block other tasks.

@eu9ene eu9ene added bug Something is broken or not correct taskcluster Issues related to the Taskcluster implementation of the training pipeline labels May 23, 2024
@gabrielBusta
Copy link
Member

Hmm, maybe it's because continuation used to be done at graph generation time rather than at run-time? Perhaps we can prune these eval tasks from the graph using its parameters. Alternatively, we could have the eval tasks exit successfully without doing anything if they detect that the model was pretrained.

@eu9ene
Copy link
Collaborator Author

eu9ene commented Jul 10, 2024

We should remove any redundant tasks from the graph. We can assume the pre-trained model has already been evaluated.

@bhearsum
Copy link
Collaborator

Hmm, maybe it's because continuation used to be done at graph generation time rather than at run-time? Perhaps we can prune these eval tasks from the graph using its parameters. Alternatively, we could have the eval tasks exit successfully without doing anything if they detect that the model was pretrained.

As far as I can tell, the run that was linked to is not using runtime continuation. I suspect this regressed with one of the recent-ish changes to train.py: https://github.com/mozilla/firefox-translations-training/commits/main/taskcluster/translations_taskgraph/actions/train.py

bhearsum added a commit to bhearsum/firefox-translations-training that referenced this issue Jul 30, 2024
This is prep work for mozilla#628, where I'd like to add some tests to avoid regressing that again in the future.

The fixtures here are based on similar tests from Gecko: https://searchfox.org/mozilla-central/source/taskcluster/test. There's a bit of a terrible hack to make optimized task graphs testable, described more in the comments.
bhearsum added a commit to bhearsum/firefox-translations-training that referenced this issue Jul 30, 2024
This is prep work for mozilla#628, where I'd like to add some tests to avoid regressing that again in the future.

The fixtures here are based on similar tests from Gecko: https://searchfox.org/mozilla-central/source/taskcluster/test. There's a bit of a terrible hack to make optimized task graphs testable, described more in the comments.
@bhearsum bhearsum self-assigned this Jul 31, 2024
bhearsum added a commit to bhearsum/firefox-translations-training that referenced this issue Jul 31, 2024
This is prep work for mozilla#628, where I'd like to add some tests to avoid regressing that again in the future.

The fixtures here are based on similar tests from Gecko: https://searchfox.org/mozilla-central/source/taskcluster/test. There's a bit of a terrible hack to make optimized task graphs testable, described more in the comments.
bhearsum added a commit to bhearsum/firefox-translations-training that referenced this issue Aug 7, 2024
This is prep work for mozilla#628, where I'd like to add some tests to avoid regressing that again in the future.

The fixtures here are based on similar tests from Gecko: https://searchfox.org/mozilla-central/source/taskcluster/test. There's a bit of a terrible hack to make optimized task graphs testable, described more in the comments.
bhearsum added a commit to bhearsum/firefox-translations-training that referenced this issue Aug 7, 2024
This is prep work for mozilla#628, where I'd like to add some tests to avoid regressing that again in the future.

The fixtures here are based on similar tests from Gecko: https://searchfox.org/mozilla-central/source/taskcluster/test. There's a bit of a terrible hack to make optimized task graphs testable, described more in the comments.
bhearsum added a commit to bhearsum/firefox-translations-training that referenced this issue Aug 7, 2024
This is prep work for mozilla#628, where I'd like to add some tests to avoid regressing that again in the future.

The fixtures here are based on similar tests from Gecko: https://searchfox.org/mozilla-central/source/taskcluster/test. There's a bit of a terrible hack to make optimized task graphs testable, described more in the comments.
bhearsum added a commit that referenced this issue Aug 7, 2024
This is prep work for #628, where I'd like to add some tests to avoid regressing that again in the future.

The fixtures here are based on similar tests from Gecko: https://searchfox.org/mozilla-central/source/taskcluster/test. There's a bit of a terrible hack to make optimized task graphs testable, described more in the comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not correct taskcluster Issues related to the Taskcluster implementation of the training pipeline
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants