Gcs pipeline #1818

pattersonbl2 · 2024-03-25T15:08:19Z

Opening pr for stage gcs bucket deploy pipeline.

willdurand · 2024-04-04T11:00:23Z

.github/workflows/gcp_deploy.yaml

+        with:
+          credentials_json: ${{ secrets.GCP_SA_KEY }}
+
+      - name: set up gcloud


Suggested change

- name: set up gcloud

- name: Set up gcloud

willdurand · 2024-04-04T11:00:34Z

.github/workflows/gcp_deploy.yaml

+      - name: set up gcloud
+        uses: google-github-actions/setup-gcloud@v2
+
+      - name: stage build with unpublsiehd contents


Suggested change

- name: stage build with unpublsiehd contents

- name: Build the website

.github/workflows/gcp_deploy.yaml

willdurand · 2024-04-04T11:01:32Z

.github/workflows/gcp_deploy.yaml

+          yarn build:production
+      - name: Deploying unpublsiehd content to stage.
+        run: |
+          sh ./bin/gcs-deploy.sh  ${{vars.EXTENSIONWORKSHOP_BUCKET_STAGE}}


Suggested change

sh ./bin/gcs-deploy.sh ${{vars.EXTENSIONWORKSHOP_BUCKET_STAGE}}

sh ./bin/gcs-deploy.sh ${{ vars.EXTENSIONWORKSHOP_BUCKET_STAGE }}

willdurand · 2024-04-04T11:01:53Z

.github/workflows/gcp_deploy_prod.yaml

+  push:
+    tags:
+      - "20[0-9][0-9].[0-9][0-9].[0-9][0-9](-[0-9]+)?"
+  workflow_dispatch:


Do we need this?

not in the longer term, workflow dispatch just allows me to run the workflow manually without waiting on the pushed git tag. So i can build a prod website during testing without creating multiple tags that will trigger the existing pipeline.

willdurand · 2024-04-04T11:07:00Z

.github/workflows/gcp_deploy_prod.yaml

+        run: |
+          yarn install
+          yarn build:production
+      - name: Deploying unpublsiehd content to stage.


Suggested change

- name: Deploying unpublsiehd content to stage.

- name: Deploy the website to prod

willdurand · 2024-04-04T11:07:21Z

.github/workflows/gcp_deploy_prod.yaml

+          yarn build:production
+      - name: Deploying unpublsiehd content to stage.
+        run: |
+          sh ./bin/gcs-deploy.sh  ${{vars.EXTENSIONWORKSHOP_BUCKET_PROD}}


Suggested change

sh ./bin/gcs-deploy.sh ${{vars.EXTENSIONWORKSHOP_BUCKET_PROD}}

sh ./bin/gcs-deploy.sh ${{ vars.EXTENSIONWORKSHOP_BUCKET_PROD }}

willdurand · 2024-04-04T11:29:37Z

bin/build-version-json.sh

@@ -0,0 +1,14 @@
+#!/bin/bash


Why is this copied? Can't we reuse .utils/build-version-json.sh?

because it being used in the gcs_deploy.sh script. i wanted both grouped together to keep track of them. just so i can keep things circle ci related separate from my work.

I am probably going to change some things here. would you like if the GitHub run number include ? it's a

"unique number for each run of a particular workflow in a repository. This number begins at 1 for the workflow's first run, and increments with each new run. This number does not change if you re-run the workflow run."

sorry, include what? The unique number? Like we have, e.g. here for AMO frontend (build)?

Yeah it would be similar to that.

Oh ok, I guess if this could be a link that'd be great. If it's just a numeric ID, I guess that's better than nothing. What matters the most for me is to have the git tag or git hash in this version.json file.

bin/gcs-deploy.sh

willdurand · 2024-04-04T11:30:30Z

bin/gcs-deploy.sh

+set -ex
+ EXTENSION_WORKSHOP_BUCKET_GCS=$1
+
+ echo $EXTENSION_WORKSHOP_BUCKET_GCS


Is there a reason for this script to be slightly indented?

No, reason could just a linting problem in my vs code set up.

I have added a test job before the deploy job , fix spelling errors and move op scripts

increase checkout depth with tags and fix error with version file not being copied.

dlactin · 2024-04-05T14:54:30Z

.github/workflows/gcp_deploy.yaml

+      - name: Setup Node js
+        uses: actions/setup-node@v3
+
+      - name: Set up Google Cloud SDK


@pattersonbl2 already mentioned this was on his radar, but the only change I'd make here is using workload identity instead of passing around a service account key. https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform

otherwise lgtm!

willdurand

Only nits but would be good to make the yaml consistent, and the shell script indented.

willdurand · 2024-04-05T14:56:29Z

.github/workflows/gcp_deploy.yaml

+      - name: Install dependencies
+        run: yarn install --immutable
+      - name: Test current build


Suggested change

- name: Install dependencies

run: yarn install --immutable

- name: Test current build

- name: Install dependencies

run: yarn install --immutable

- name: Test current build

willdurand · 2024-04-05T14:56:43Z

.github/workflows/gcp_deploy.yaml

+        run: |
+          yarn install
+          yarn build:production
+      - name: Build version.json file


Suggested change

- name: Build version.json file

- name: Build version.json file

willdurand · 2024-04-05T14:56:57Z

.github/workflows/gcp_deploy_prod.yaml

+      - name: Install dependencies
+        run: yarn install --immutable
+      - name: Test current build


Suggested change

- name: Install dependencies

run: yarn install --immutable

- name: Test current build

- name: Install dependencies

run: yarn install --immutable

- name: Test current build

willdurand · 2024-04-05T14:57:32Z

.github/workflows/gcp_deploy_prod.yaml

+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+      - name: Setup Node js


Suggested change

- name: Setup Node js

- name: Setup Node.js

willdurand · 2024-04-05T14:57:43Z

.github/workflows/gcp_deploy_prod.yaml

+          fetch-depth: 1
+          fetch-tags: true
+
+      - name: Setup Node js


Suggested change

- name: Setup Node js

- name: Setup Node.js

willdurand · 2024-04-05T14:58:02Z

.github/workflows/gcp_deploy.yaml

+          echo "version.json exists, skipping build"
+          else
+          echo "version.json does not exist, running build-version-json.sh"
+          bash  ./.utils/build-version-json.sh


Suggested change

echo "version.json exists, skipping build"

else

echo "version.json does not exist, running build-version-json.sh"

bash ./.utils/build-version-json.sh

echo "version.json exists, skipping build"

else

echo "version.json does not exist, running build-version-json.sh"

bash ./.utils/build-version-json.sh

willdurand · 2024-04-05T14:58:11Z

.github/workflows/gcp_deploy.yaml

+          fetch-depth: 1
+          fetch-tags: true
+
+      - name: Setup Node js


Suggested change

- name: Setup Node js

- name: Setup Node.js

willdurand · 2024-04-05T14:58:24Z

.github/workflows/gcp_deploy.yaml

+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Setup Node js


Suggested change

- name: Setup Node js

- name: Setup Node.js

willdurand · 2024-04-05T14:58:56Z

.github/workflows/gcp_deploy_prod.yaml

+      - name: Build version.json file
+        run: |
+          if [ -e version.json ]; then
+          echo "version.json exists, skipping build"
+          else
+          echo "version.json does not exist, running build-version-json.sh"
+          bash  ./.utils/build-version-json.sh
+          fi


Suggested change

- name: Build version.json file

run: |

if [ -e version.json ]; then

echo "version.json exists, skipping build"

else

echo "version.json does not exist, running build-version-json.sh"

bash ./.utils/build-version-json.sh

fi

- name: Build version.json file

run: |

if [ -e version.json ]; then

echo "version.json exists, skipping build"

else

echo "version.json does not exist, running build-version-json.sh"

bash ./.utils/build-version-json.sh

fi

.utils/gcs-deploy.sh

pattersonbl2 · 2024-04-05T16:47:19Z

I can make these changes today

.github/workflows/gcp_deploy.yaml

.github/workflows/gcp_deploy_prod.yaml

Co-authored-by: William Durand <[email protected]>

pattersonbl2 added 19 commits March 5, 2024 14:09

feat/github-action

59fd4a1

feat/ updated github action location

757758f

wip

2867028

wip

44d3b3f

wip

575b7d7

wip

ec5cf4d

wip

9306870

wip

10776e4

wip

9d1a293

wip

c3d502c

wip

ec3a492

wip

025a379

wip

fcec48e

wip

bd1b7be

wip

cd42240

wip

ee40551

wip prod pipeline

65ac796

adding prod pipeline

4094f6f

adding json build

de6b4dc

pattersonbl2 temporarily deployed to stage April 2, 2024 14:41 — with GitHub Actions Inactive

wip

7fd8180

pattersonbl2 temporarily deployed to stage April 3, 2024 16:06 — with GitHub Actions Inactive

willdurand reviewed Apr 4, 2024

View reviewed changes

Updating Gcs pipeline

6d91103

I have added a test job before the deploy job , fix spelling errors and move op scripts

pattersonbl2 had a problem deploying to stage April 4, 2024 19:05 — with GitHub Actions Failure

fix/errors in github action.

8f4d215

increase checkout depth with tags and fix error with version file not being copied.

pattersonbl2 had a problem deploying to stage April 4, 2024 20:09 — with GitHub Actions Failure

fix/ version upload

0e531a5

pattersonbl2 had a problem deploying to stage April 4, 2024 20:42 — with GitHub Actions Failure

Update gcs-deploy.sh

cb57e13

pattersonbl2 had a problem deploying to stage April 4, 2024 20:46 — with GitHub Actions Failure

Update gcs-deploy.sh

9fdcf49

pattersonbl2 had a problem deploying to stage April 4, 2024 21:00 — with GitHub Actions Failure

Update gcs-deploy.sh

46234ad

pattersonbl2 temporarily deployed to stage April 4, 2024 21:10 — with GitHub Actions Inactive

dlactin approved these changes Apr 5, 2024

View reviewed changes

willdurand approved these changes Apr 5, 2024

View reviewed changes

pattersonbl2 added 2 commits April 5, 2024 14:56

Formatting code for easier readability

b4c6521

Formatting code for easier readability

9ed371e

willdurand approved these changes Apr 9, 2024

View reviewed changes

.github/workflows/gcp_deploy.yaml Outdated Show resolved Hide resolved

.github/workflows/gcp_deploy_prod.yaml Outdated Show resolved Hide resolved

pattersonbl2 and others added 2 commits April 9, 2024 11:15

Update .github/workflows/gcp_deploy_prod.yaml

cacb03c

Co-authored-by: William Durand <[email protected]>

Update .github/workflows/gcp_deploy.yaml

91bd40d

Co-authored-by: William Durand <[email protected]>

pattersonbl2 merged commit 50c329f into master Apr 9, 2024
1 check passed

pattersonbl2 deleted the gcs-pipeline branch April 9, 2024 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gcs pipeline #1818

Gcs pipeline #1818

pattersonbl2 commented Mar 25, 2024

willdurand Apr 4, 2024

willdurand Apr 4, 2024

willdurand Apr 4, 2024

willdurand Apr 4, 2024

pattersonbl2 Apr 4, 2024

willdurand Apr 4, 2024

willdurand Apr 4, 2024

willdurand Apr 4, 2024

pattersonbl2 Apr 4, 2024

pattersonbl2 Apr 4, 2024

willdurand Apr 4, 2024

pattersonbl2 Apr 4, 2024

willdurand Apr 5, 2024

willdurand Apr 4, 2024

pattersonbl2 Apr 4, 2024

dlactin Apr 5, 2024 •

edited

Loading

willdurand left a comment

willdurand Apr 5, 2024

willdurand Apr 5, 2024

willdurand Apr 5, 2024

willdurand Apr 5, 2024

willdurand Apr 5, 2024

willdurand Apr 5, 2024

willdurand Apr 5, 2024

willdurand Apr 5, 2024

willdurand Apr 5, 2024

pattersonbl2 commented Apr 5, 2024

	- name: stage build with unpublsiehd contents
	- name: Build the website

	sh ./bin/gcs-deploy.sh ${{vars.EXTENSIONWORKSHOP_BUCKET_STAGE}}
	sh ./bin/gcs-deploy.sh ${{ vars.EXTENSIONWORKSHOP_BUCKET_STAGE }}

	- name: Deploying unpublsiehd content to stage.

	- name: Deploy the website to prod

	- name: Build version.json file

	- name: Build version.json file

Gcs pipeline #1818

Gcs pipeline #1818

Conversation

pattersonbl2 commented Mar 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlactin Apr 5, 2024 • edited Loading

Choose a reason for hiding this comment

willdurand left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pattersonbl2 commented Apr 5, 2024

dlactin Apr 5, 2024 •

edited

Loading